Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add deploymentLabels variable #22541

Merged
merged 3 commits into from
Jan 5, 2023

Conversation

mathieuherbert
Copy link
Contributor

Signed-off-by: Mathieu Herbert math.herbert@gmail.com

add deploymentLabels as we have for annotations.

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

# -- Annotations to be added to supersetNode deployment
deploymentAnnotations: {}
# -- Labels to be added to supersetNode deployment
deploymentLabels: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls update the schema to reflect this addition

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, fixed thanks !

@villebro villebro changed the title add deploymentLabels variable feat(helm): add deploymentLabels variable Dec 31, 2022
@craig-rueda
Copy link
Member

Still looking like there's failed checks

@craig-rueda
Copy link
Member

Pls rebase after this merges: #22590

(should fix linting errors)

Mathieu Herbert added 2 commits January 5, 2023 11:27
Signed-off-by: Mathieu Herbert <math.herbert@gmail.com>
Signed-off-by: Mathieu Herbert math.herbert@gmail.com
@mathieuherbert
Copy link
Contributor Author

mathieuherbert commented Jan 5, 2023

Hey, rebased is done

@craig-rueda
Copy link
Member

Pls make sure you run helm-docs to generate the readme. Looks like that check is still failing

@craig-rueda craig-rueda merged commit d6bce09 into apache:master Jan 5, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants